Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuttx: Remove unnecessary include in ADC module #1867

Merged

Conversation

rzr
Copy link
Contributor

@rzr rzr commented Apr 25, 2019

Currently that platform header defines only one function:
"iotjs_stm32f4dis_pin_initialize".

It's platform specific and called elsewhere:
./src/modules/iotjs_module_stm32f4dis.c

So it's safe to remove this probable leftover
to support more boards (STMF7 ones to come).

Change-Id: If22dbf1797fec20161203661b044845f55d2e378
Relate-to: rzr/webthing-iotjs#3
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com

Currently that platform header defines only one function:
"iotjs_stm32f4dis_pin_initialize".

It's platform specific and called elsewhere:
./src/modules/iotjs_module_stm32f4dis.c

So it's safe to remove this probable leftover
to support more boards (STMF7 ones to come).

Change-Id: If22dbf1797fec20161203661b044845f55d2e378
Relate-to: rzr/webthing-iotjs#3
Forwarded: jerryscript-project#1867
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval p.coval@samsung.com
@rzr rzr force-pushed the sandbox/rzr/review/master branch from 5adaa24 to b07b9f4 Compare April 25, 2019 11:02
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hs0225 hs0225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yichoi yichoi merged commit b31e0ac into jerryscript-project:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants